-
-
Couldn't load subscription status.
- Fork 33.3k
gh-111062 CI: Update skip lists for resuable workflows #111521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@webknjaz How does this look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugovk this should do. Although, the pre-reusable workflow might've required less jobs, IIRC. Nevertheless, this state is probably what you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…111521) CI: Update skip lists
…111521) CI: Update skip lists
…111521) CI: Update skip lists
Add all the top-level jobs on the
needsandallowed-skipslists, and add thebuild_*_free_threadedjobs on theallowed_failureslist.Rename
build_win32,build_win_amd64andbuild_win_arm64tobuild_windowsandbuild_windows_free_threadedin the skip/allow lists now they're in reusable workflows.Here's a test build on my fork showing a docs-only build completing: hugovk#58
Compare #111509 which "failed" the "All required checks pass" check.