Skip to content

gh-111119: Fix flaky test test_lock_two_threads #111124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

gh-111119: Fix flaky test test_lock_two_threads #111124

merged 1 commit into from
Oct 20, 2023

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Oct 20, 2023 •
edited by bedevere-app bot
Loading

This allows for more time for the "lock thread" to attempt to lock the mutex (up to two seconds before timing out).

@colesbury
pythongh-111119: Fix flaky test test_lock_two_threads
eeaa70b 
This allows for more time for the "lock thread" to attempt to lock the
mutex (up to two seconds before timing out).
@colesbury colesbury added skip news 3.13 bugs and security fixes labels Oct 20, 2023
@colesbury colesbury requested a review from corona10 October 20, 2023 16:22
@bedevere-app bedevere-app bot mentioned this pull request Oct 20, 2023
Closed
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Oct 20, 2023
corona10
corona10 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 enabled auto-merge (squash) October 20, 2023 16:31
@corona10 corona10 merged commit 264f4af into python:main Oct 20, 2023
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Oct 20, 2023

Should this be backported?

@colesbury
Copy link
Contributor Author

colesbury commented Oct 20, 2023

@erlend-aasland, no the test is not present in earlier versions of CPython

@colesbury colesbury deleted the test_lock branch October 20, 2023 17:39
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@colesbury @aisk
pythongh-111119: Fix flaky test test_lock_two_threads (pythongh-111124)
d15e8c0
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@colesbury @Glyphack
pythongh-111119: Fix flaky test test_lock_two_threads (pythongh-111124)
5947ab4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Assignees

No one assigned

Labels

3.13 bugs and security fixes skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury @erlend-aasland @corona10