regrtest: Prepend 'use' options in --{fast,slow}-ci #110363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows individual resources to be disabled without having to explicitly re-enable all others.
vstinner
reviewed
Oct 5, 2023
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Please add more tests to test_regrtest.test_use() when -u option is specified more than once.
This change allows to only enable/disable some resources, without having to override all resources set previously be a previous -u, --fast-ci or --slow-ci option. I think that it's a reasonable choice.
For example, --slow-ci -u-gui run tests with -u all,-gui. Previously, tests were run with... no resource enabled at all. I just saw that some buildbots use something like --slow-ci -u-cpu and now all resources are disabled.
@serhiy-storchaka: Are you fine with the new behavior?
serhiy-storchaka
approved these changes
Oct 15, 2023
vstinner
added
needs backport to 3.11
Contributor
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 16, 2023
This allows individual resources to be disabled without having to explicitly re-enable all others. (cherry picked from commit b75186f) Co-authored-by: Zachary Ware <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 16, 2023
This allows individual resources to be disabled without having to explicitly re-enable all others. (cherry picked from commit b75186f) Co-authored-by: Zachary Ware <[email protected]>
|
GH-110924 is a backport of this pull request to the 3.11 branch. |
|
GH-110925 is a backport of this pull request to the 3.12 branch. |
Member
|
Please backport libregrtest changes to 3.11 and 3.12 branches. I just did it. |
vstinner
pushed a commit
that referenced
this pull request
Oct 16, 2023
#110925) regrtest: Prepend 'use' options in --{fast,slow}-ci (GH-110363) This allows individual resources to be disabled without having to explicitly re-enable all others. (cherry picked from commit b75186f) Co-authored-by: Zachary Ware <[email protected]>
vstinner
pushed a commit
that referenced
this pull request
Oct 16, 2023
#110924) regrtest: Prepend 'use' options in --{fast,slow}-ci (GH-110363) This allows individual resources to be disabled without having to explicitly re-enable all others. (cherry picked from commit b75186f) Co-authored-by: Zachary Ware <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
This allows individual resources to be disabled without having to explicitly re-enable all others.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This allows individual resources to be disabled without having to explicitly re-enable all others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows individual resources to be disabled without having to
explicitly re-enable all others.