gh-110178: Use fewer weakrefs in test_typing.py #110194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed that without the C changes from python#108517, this test still segfaults with only 10 weakrefs.
JelleZijlstra
requested review from
AlexWaygood,
Fidget-Spinner and
gvanrossum
as code owners
AlexWaygood
approved these changes
Oct 1, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! I have not verified that it still segfaults with only 10 weakrefs without the fix, but I trust you to have checked properly :D
Contributor
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 2, 2023
Confirmed that without the C changes from pythonGH-108517, this test still segfaults with only 10 weakrefs. (cherry picked from commit 732ad44) Co-authored-by: Jelle Zijlstra <[email protected]>
|
GH-110224 is a backport of this pull request to the 3.12 branch. |
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Confirmed that without the C changes from python#108517, this test still segfaults with only 10 weakrefs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed that without the C changes from #108517, this test still segfaults with only 10 weakrefs.
test_typing:test_many_weakrefstakes many seconds #110178