Skip to content

gh-109566: regrtest --fast-ci no longer enables --nowindow #110121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2023
Merged

gh-109566: regrtest --fast-ci no longer enables --nowindow #110121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6efcff1
gh-109566: regrtest --fast-ci no longer enables --nowindow
vstinner Sep 29, 2023
fd5957e
Update test_regrtest on Windows
vstinner Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Lib/test/libregrtest/cmdline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import sys
from test.support import os_helper

from .utils import MS_WINDOWS


USAGE = """\
python -m test [options] [test_name1 [test_name2 ...]]
Expand Down Expand Up @@ -414,7 +412,7 @@ def _parse_args(args, **kwargs):
# Similar to options:
#
# -j0 --randomize --fail-env-changed --fail-rerun --rerun
# --slowest --verbose3 --nowindows
# --slowest --verbose3
if ns.use_mp is None:
ns.use_mp = 0
ns.randomize = True
Expand All @@ -424,8 +422,6 @@ def _parse_args(args, **kwargs):
ns.rerun = True
ns.print_slow = True
ns.verbose3 = True
if MS_WINDOWS:
ns.nowindows = True # Silence alerts under Windows
else:
ns._add_python_opts = False

Expand Down
2 changes: 0 additions & 2 deletions Lib/test/test_regrtest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,8 +376,6 @@ def test_unknown_option(self):

def check_ci_mode(self, args, use_resources, rerun=True):
ns = cmdline._parse_args(args)
if utils.MS_WINDOWS:
self.assertTrue(ns.nowindows)

# Check Regrtest attributes which are more reliable than Namespace
# which has an unclear API
Expand Down