Skip to content

gh-109276: regrtest re-runs "env changed" tests #109831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

gh-109276: regrtest re-runs "env changed" tests #109831

merged 1 commit into from
Sep 25, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 25, 2023 •
edited by bedevere-app bot
Loading

When a test fails with "env changed" and --rerun option is used, the test is now re-run in verbose mode in a fresh process.

@vstinner
pythongh-109276: regrtest re-runs "env changed" tests
a090e59 
When a test fails with "env changed" and --rerun option is used, the
test is now re-run in verbose mode in a fresh process.
@bedevere-app bedevere-app bot mentioned this pull request Sep 25, 2023
Closed
@vstinner
Copy link
Member Author

I wrote this change to debug issue gh-109832:

Warning -- sys.stderr was modified by test.test_concurrent_futures.test_deadlock
Warning --   Before: <_io.TextIOWrapper name='<stderr>' mode='w' encoding='utf-8'>
Warning --   After:  <_io.StringIO object at 0x3ff971b6410>

build: https://buildbot.python.org/all/#/builders/75/builds/895

@vstinner vstinner merged commit 72fb39c into python:main Sep 25, 2023
@vstinner vstinner deleted the regrtest_rerun_env_changed branch September 25, 2023 14:21
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vstinner @csm10495
pythongh-109276: regrtest re-runs "env changed" tests (python#109831)
82ab866 
When a test fails with "env changed" and --rerun option is used, the
test is now re-run in verbose mode in a fresh process.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-109276: regrtest re-runs "env changed" tests (python#109831)
0e8f38d 
When a test fails with "env changed" and --rerun option is used, the
test is now re-run in verbose mode in a fresh process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner