[3.11] gh-108558: Improve sqlite3 row factory tests (GH-108578) #108616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test_sqlite_row_keys() to explicitly test sqlite3.Row.keys(). Cleanups: - Reduce test noise by converting docstrings to regular comments - Reduce boilerplate code by adding a setUp() method to RowFactoryTests (cherry picked from commit 6eaddc1) Co-authored-by: Edward Schauman-Haigh <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington
requested review from
berkerpeksag and
erlend-aasland
as code owners
This was referenced Aug 29, 2023
erlend-aasland
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test_sqlite_row_keys() to explicitly test sqlite3.Row.keys().
Cleanups:
(cherry picked from commit 6eaddc1)
Co-authored-by: Edward Schauman-Haigh [email protected]
Co-authored-by: Erlend E. Aasland [email protected]