-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-107995: Fix doctest collection of functools.cached_property objects #107996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
4e2f44b to
3d02d97
Compare
sobolevn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
3d02d97 to
da2616d
Compare
da2616d to
4591a60
Compare
AlexWaygood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You can also add your name to this file here, if you like, but it isn't mandatory: https://github.com/python/cpython/blob/main/Misc/ACKS
|
By the way, for future PRs to CPython, please avoid force-pushing where possible. It interacts badly with the GitHub UI, making it hard for reviewers to see what changed between commits. We merge everything using GitHub's "squash and merge" button in CPython, so we don't care about a messy commit history for a PR :-) |
Sounds good. Thanks for the heads up! 👍 |
carljm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
DocTestFinderwould skipfunctools.cached_propertyobjects because they were not considered to be a part of the module that it is collecting doc tests from. To fix this issue I added a check forcached_propertythat grabs the underlying function, similar to what is done forstaticmethodandclassmethod.