Skip to content

GH-104584: Fix incorrect uoperands #107513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 31, 2023
Merged

GH-104584: Fix incorrect uoperands #107513

merged 3 commits into from
Jul 31, 2023

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Jul 31, 2023 •
edited by bedevere-bot
Loading

There's currently an off-by-one error during trace construction that causes incorrect values to be loaded from the inline caches.

This fix results in a significant reduction in deoptimization events, and a dramatic improvement in our ability to stay on trace!

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 31, 2023
@brandtbucher brandtbucher requested a review from gvanrossum July 31, 2023 20:43
@brandtbucher brandtbucher self-assigned this Jul 31, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 31, 2023
Closed
gvanrossum
gvanrossum approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'm surprised this never showed when I tested things. I guess it just caused excessive cache failures. :-(

@brandtbucher brandtbucher enabled auto-merge (squash) July 31, 2023 21:16
@brandtbucher brandtbucher merged commit 5e584eb into python:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandtbucher @gvanrossum @bedevere-bot