Skip to content

GH-104909: Move unused cache entries from uops to macros #107444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2023
Merged

GH-104909: Move unused cache entries from uops to macros #107444

merged 2 commits into from
Jul 31, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jul 29, 2023 •
edited by bedevere-bot
Loading

There's no need to use a dummy uop to skip unused cache entries. The macro syntax lets you write unused/1 instead.

Similarly, move unused/5 from op _LOAD_ATTR_INSTANCE_VALUE to macro LOAD_ATTR_INSTANCE_VALUE.

@gvanrossum gvanrossum requested a review from markshannon July 29, 2023 21:02
@bedevere-bot bedevere-bot mentioned this pull request Jul 29, 2023
Closed
markshannon
markshannon approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@gvanrossum gvanrossum merged commit 5eb80a6 into python:main Jul 31, 2023
@gvanrossum gvanrossum deleted the rm-skip-cache-uop branch July 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gvanrossum @markshannon @bedevere-bot