Skip to content

gh-104050: Argument clinic: annotate post_parsing() and cleanup() #107225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2023
Merged

gh-104050: Argument clinic: annotate post_parsing() and cleanup() #107225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cf5f61
Argument clinic: annotate `post_parsing()` and `cleanup()`
AlexWaygood Jul 25, 2023
d0d4ca2
Merge branch 'main' into clinic-dodgy-methods
AlexWaygood Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3664,10 +3664,12 @@ def converter_init(
if NoneType in accept and self.c_default == "Py_None":
self.c_default = "NULL"

def post_parsing(self):
def post_parsing(self) -> str:
if self.encoding:
name = self.name
return f"PyMem_FREE({name});\n"
else:
return ""

def parse_arg(self, argname: str, displayname: str) -> str:
if self.format_unit == 's':
Expand Down Expand Up @@ -3845,8 +3847,10 @@ def converter_init(
fail("Py_UNICODE_converter: illegal 'accept' argument " + repr(accept))
self.c_default = "NULL"

def cleanup(self):
if not self.length:
def cleanup(self) -> str:
if self.length:
return ""
else:
return """\
PyMem_Free((void *){name});
""".format(name=self.name)
Expand Down