Skip to content

Add Erlend as CODEOWNER for Argument Clinic docs #106840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2023
Merged

Add Erlend as CODEOWNER for Argument Clinic docs #106840

merged 2 commits into from
Jul 17, 2023

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 17, 2023

No description provided.

AlexWaygood
AlexWaygood reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, not sure. I'm increasingly familiar with the Python code in Tools/clinic/, and I have a broad understanding of how it all works... but I wouldn't necessarily call myself an expert in using AC just yet 😆

(I'm obviously always happy to review docs PRs whenever you'd like me to :)

ezio-melotti
ezio-melotti reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically you don't need to be an expert to be added to CODEOWNERS, since its main function is to request your review and ping you when someone makes a PR that touches the listed files.

If you don't want to be pinged, then it's ok not to be listed, whether you are an expert or not.

@AlexWaygood
Copy link
Member

AlexWaygood commented Jul 17, 2023

Technically you don't need to be an expert to be added to CODEOWNERS, since its main function is to request your review and ping you when someone makes a PR that touches the listed files.

I know. But I already get a lot of pings on a lot of things, and I guess I'd prefer not to have automated review on things where I don't feel like I'm an expert yet :)

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 17, 2023

I know. But I already get a lot of pings on a lot of things, and I guess I'd prefer not to have automated review on things where I don't feel like I'm an expert yet :)

No stress, I'll ping you manually for these PRs 😆

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 17, 2023

More seriously: no sweat; I've removed you :) I promise I'll only ping you if needed.

@erlend-aasland erlend-aasland changed the title Add Alex and Erlend as CODEOWNER for Argument Clinic docs Add Erlend as CODEOWNER for Argument Clinic docs Jul 17, 2023
AlexWaygood
AlexWaygood approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✍️🚀

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 17, 2023 21:44
@erlend-aasland erlend-aasland merged commit 1654916 into python:main Jul 17, 2023
@erlend-aasland erlend-aasland deleted the clinic/codeowners branch August 3, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland @AlexWaygood @ezio-melotti @bedevere-bot