gh-105332: [Enum] Fix unpickling flags in edge-cases #105348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfurman
changed the title
enum.Flag with specific values
ethanfurman
approved these changes
Jun 8, 2023
ethanfurman
added
type-bug
|
Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry @sobolevn and @ethanfurman, I had trouble checking out the |
|
GH-105519 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 8, 2023
…105348) * revert enum pickling from by-name to by-value (cherry picked from commit 4ff5690) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Ethan Furman <[email protected]>
ethanfurman
added
3.12
|
Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 8, 2023
…105348) * revert enum pickling from by-name to by-value (cherry picked from commit 4ff5690) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Ethan Furman <[email protected]>
|
GH-105520 is a backport of this pull request to the 3.12 branch. |
|
@ethanfurman thanks a lot for your help! 👍 |
ethanfurman
added a commit
that referenced
this pull request
Jun 9, 2023
… (GH-105520) * revert enum pickling from by-name to by-value (cherry picked from commit 4ff5690) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Ethan Furman <[email protected]>
ethanfurman
added a commit
that referenced
this pull request
Jun 9, 2023
… (GH-105519) * revert enum pickling from by-name to by-value (cherry picked from commit 4ff5690) Co-authored-by: Nikita Sobolev <[email protected]> Co-authored-by: Ethan Furman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only problem that this PR fixes is that
TypeError: unsupported operand type(s) for |: 'PxdEnum' and 'NoneType'does not happen anymore.It does not change any difference between 3.10 and 3.11