Skip to content

bpo-35214: Disable getc_unlocked() with MemorySanitizer. #10499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

bpo-35214: Disable getc_unlocked() with MemorySanitizer. #10499

merged 1 commit into from
Nov 13, 2018

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Nov 13, 2018 •
edited by bedevere-bot
Loading

clang's MemorySanitizer understand getc() but does not understand
getc_unlocked(). Workaround: Don't use it on msan builds.

https://bugs.python.org/issue35214

@gpshead
Disable getc_unlocked() with MemorySanitizer.
43a31f4 
clang's MemorySanitizer understand getc() but does not understand
getc_unlocked().  Workaround: Don't use it on msan builds.
@gpshead gpshead self-assigned this Nov 13, 2018
@alex
Copy link
Member

alex commented Nov 13, 2018

Is there a bug filed with MSAN (compiler-rt) for this?

@gpshead
Copy link
Member Author

gpshead commented Nov 13, 2018

Is there a bug filed with MSAN (compiler-rt) for this?

Looking into that... Someone on our internal clang team said this (in 2015) on an internal bug that was was fixed using this workaround instead because of:

"""This can be fixed in MSan, but it may take time. The whole thing is quite messy: _unlocked IO functions access internals of FILE* in glibc headers, which means that MSan needs to catch all cases when glibc (an uninstrumented library) updates buffer pointers inside FILE and unpoison the new target region.

Disabling HAVE_GETC_UNLOCKED under #ifdef MEMORY_SANITIZER is definitely better than what we have now."""

I'm pointing them here to see if anything about that has changed (I'd assume not) while I wait for a clang compiler-rt bugzilla account to be created for me.

@gpshead gpshead merged commit e6c77d8 into python:master Nov 13, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Nov 13, 2018

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@gpshead gpshead deleted the msan-vs-getc_unlocked branch November 13, 2018 03:47
@bedevere-bot
Copy link

bedevere-bot commented Nov 13, 2018

GH-10500 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2018
@gpshead @miss-islington
Disable getc_unlocked() with MemorySanitizer. (pythonGH-10499)
3fcc145 
clang's MemorySanitizer understand getc() but does not understand
getc_unlocked().  Workaround: Don't use it on msan builds.
(cherry picked from commit e6c77d8)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Nov 13, 2018

GH-10501 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2018
@gpshead @miss-islington
Disable getc_unlocked() with MemorySanitizer. (pythonGH-10499)
d8d997b 
clang's MemorySanitizer understand getc() but does not understand
getc_unlocked().  Workaround: Don't use it on msan builds.
(cherry picked from commit e6c77d8)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Nov 13, 2018
@miss-islington @gpshead
Disable getc_unlocked() with MemorySanitizer. (GH-10499)
f0b21e1 
clang's MemorySanitizer understand getc() but does not understand
getc_unlocked().  Workaround: Don't use it on msan builds.
(cherry picked from commit e6c77d8)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Nov 13, 2018
@miss-islington @gpshead
Disable getc_unlocked() with MemorySanitizer. (GH-10499)
41fdbaa 
clang's MemorySanitizer understand getc() but does not understand
getc_unlocked().  Workaround: Don't use it on msan builds.
(cherry picked from commit e6c77d8)

Co-authored-by: Gregory P. Smith <[email protected]>
@gpshead gpshead mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gpshead gpshead

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gpshead @alex @miss-islington @bedevere-bot @the-knights-who-say-ni