gh-104235: Fix doctest loading issues in test_enum
#104236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove invalid doc file existence check * mark path to doc as module-relative by `module_relative` flag
sunmy2019
requested changes
May 6, 2023
Lib/test/test_enum.py
Outdated
| '../../Doc/library/enum.rst', | ||
| optionflags=doctest.ELLIPSIS|doctest.NORMALIZE_WHITESPACE, | ||
| )) | ||
| tests.addTests(doctest.DocFileSuite( |
There was a problem hiding this comment.
the whole test library is shipped to the user, while the docs may not.
Keep the behavior as is please.
There was a problem hiding this comment.
I agree that docs may not be present, but I see that path that is passed to os.path.exists should be changed to "../../Doc/library/enum.rst" in this case. Not sure about module_relative flag though.
There was a problem hiding this comment.
Yeah, we need to figure out the correct path.
sunmy2019
approved these changes
May 8, 2023
|
Fixed in #111180. Thank you everyone for your efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems with
test_enummentioned in #104235.module_relativeflagenum.Enum.__dir__docs do not mention enum members in return value #104235