Skip to content

gh-100021: Document that sqlite3's executemany() discards resulting rows #103939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

gh-100021: Document that sqlite3's executemany() discards resulting rows #103939

merged 1 commit into from
Apr 28, 2023

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 27, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Apr 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request Apr 27, 2023
Closed
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 27, 2023

cc. @PascalinDe, @zentarim

@erlend-aasland erlend-aasland linked an issue Apr 27, 2023 that may be closed by this pull request
stdlib sqlite3 executemany() does not support RETURNING statement #100021
Closed
@PascalinDe
Copy link

PascalinDe commented Apr 28, 2023

cc. @PascalinDe, @zentarim

Hello, that's exactly the bit of information that was missing in the docs, thank you!

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 28, 2023

Thanks for the feedback, @PascalinDe. Highly appreciated!

@erlend-aasland erlend-aasland merged commit 30216b6 into python:main Apr 28, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2023

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@erlend-aasland erlend-aasland deleted the sqlite-fixup-executemany-docs branch April 28, 2023 08:02
@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2023

Sorry @erlend-aasland, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 30216b69a2fc716c7cfab842364a379cd6ffe458 3.11

@bedevere-bot
Copy link

bedevere-bot commented Apr 28, 2023

GH-103966 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Apr 28, 2023
erlend-aasland added a commit that referenced this pull request Apr 28, 2023
@erlend-aasland
[3.11] gh-100021: Document that sqlite3's executemany() discards resu…
b3faf8c 
…lting rows (#103939) (#103966)
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Apr 28, 2023
@erlend-aasland
[3.11] pythongh-100021: Document that sqlite3's executemany() discard…
3aff9ba 
…s resulting rows (python#103939)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

@erlend-aasland erlend-aasland

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

stdlib sqlite3 executemany() does not support RETURNING statement

4 participants

@erlend-aasland @PascalinDe @miss-islington @bedevere-bot