gh-98831: rewrite CHECK_EG_MATCH opcode in the instruction definition DSL #101269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
the
interpreter-core
gvanrossum
approved these changes
Jan 23, 2023
gvanrossum
reviewed
Jan 23, 2023
Misc/NEWS.d/next/Core and Builtins/2023-01-23-22-06-07.gh-issue-98831.FkCDuV.rst
Outdated
Show resolved
Hide resolved
This reverts commit 48d0fcb.
|
I'll kick off the buildbots in case refcount. |
iritkatriel
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 93d98ab 🤖 If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
PPC64 Fedora PR is failing with "No space left on device", so I wouldn't worry about that one. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in exception_group_match is needed because previously in the case of match == None the opcode didn't look at rest, but now it pushes to the stack (even though it's already there) to keep the code uniform with the match != None case.