Skip to content

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Dec 30, 2022

Also, add two new internal APIs (_PyFrame_GetComplete and _PyThreadState_GetFrame) to make this common move a bit cleaner.

@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-crash A hard crash of the interpreter, possibly with a core dump labels Dec 30, 2022
@brandtbucher brandtbucher self-assigned this Dec 30, 2022
@brandtbucher brandtbucher added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 30, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 53d066e 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 30, 2022
@brandtbucher
Copy link
Member Author

The one failing buildbot (ARM64 Windows) has been failing on other PRs too.

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quibble about naming.

Looks good. Hopefully this is the last of the frame stack traversal issues.

}

static inline _PyInterpreterFrame *
_PyFrame_GetComplete(_PyInterpreterFrame *frame)
Copy link
Member

@markshannon markshannon Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name gives no sense of traversing the stack until a complete frame is found.
Maybe _PyFrame_GetFirstComplete()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants