Skip to content

gh-100488: Add is_integer method to fractions.Fraction #100489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 1, 2023
Merged

gh-100488: Add is_integer method to fractions.Fraction #100489

merged 3 commits into from
Jan 1, 2023

Conversation

hauntsaninja
Copy link
Contributor

@hauntsaninja hauntsaninja commented Dec 24, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Dec 24, 2022
Closed
@hauntsaninja
Copy link
Contributor Author

The documentation guarantees that denominator is in lowest term. It doesn't make any explicit guarantee about being positive, but as_integer_ratio does and just returns the denominator. But do let me know if I should change to abs(self._denominator) == 1 or self._numerator % self._denominator == 0!

@hauntsaninja hauntsaninja mentioned this pull request Dec 24, 2022
Closed
JelleZijlstra
JelleZijlstra approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(But let's wait for Mark to also give feedback.)

mdickinson
mdickinson approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; one reST markup nitpick.

@hauntsaninja hauntsaninja merged commit e83f88a into python:main Jan 1, 2023
@hauntsaninja hauntsaninja deleted the fraction-is-integer branch January 1, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

+1 more reviewer

@mdickinson mdickinson mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hauntsaninja @mdickinson @JelleZijlstra @bedevere-bot