Remove deprecated html.parser.HTMLParser.unescape()

[serhiy-storchaka]

BPO	27032
Nosy	@terryjreedy, @orsenthil, @ezio-melotti, @bitdancer, @methane, @ambv, @berkerpeksag, @vadmium, @JimJJewett, @serhiy-storchaka, @iritkatriel
PRs	bpo-27032, bpo-37328: Document removing HTMLParser.unescape(). #22288 [3.9] bpo-27032, bpo-37328: Document removing HTMLParser.unescape() (GH-22288) #22293
Files	html_parser_remove_deprecated.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-09-18.00:48:26.321>
created_at = <Date 2016-05-15.19:05:46.052>
labels = ['type-feature', 'library', '3.9', '3.10']
title = 'Remove deprecated html.parser.HTMLParser.unescape()'
updated_at = <Date 2020-10-05.16:10:19.495>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2020-10-05.16:10:19.495>
actor = 'lukasz.langa'
assignee = 'none'
closed = True
closed_date = <Date 2020-09-18.00:48:26.321>
closer = 'terry.reedy'
components = ['Library (Lib)']
creation = <Date 2016-05-15.19:05:46.052>
creator = 'serhiy.storchaka'
dependencies = []
files = ['42864']
hgrepos = []
issue_num = 27032
keywords = ['patch']
message_count = 14.0
messages = ['265643', '266150', '266326', '266338', '266350', '266351', '377030', '377031', '377036', '377046', '377056', '377075', '377079', '378047']
nosy_count = 11.0
nosy_names = ['terry.reedy', 'orsenthil', 'ezio.melotti', 'r.david.murray', 'methane', 'lukasz.langa', 'berker.peksag', 'martin.panter', 'Jim.Jewett', 'serhiy.storchaka', 'iritkatriel']
pr_nums = ['22288', '22293']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue27032'
versions = ['Python 3.9', 'Python 3.10']

[serhiy-storchaka]

Proposed patch removes the unescape() method in the html.parser.HTMLParser class. This was deprecated since Python 3.4 (bpo-19688).

[jimjjewett]

Looks Good To Me

[vadmium]

I wonder if removing HTMLParser().unescape() would hurt Python 2 → 3 compatibility. This was mentioned in Ezio’s draft deprecation policy PEP <https://mail.python.org/pipermail/python-committers/2016-January/003706.html\>: “nothing that is available and not deprecated in 2.7 should be removed from Python 3 as long as 2.7 is officially supported”.

Is there any pressing need to get rid of the method? Maybe just fix the reference to Python 3.5 for the time being.

[serhiy-storchaka]

Good point. Maybe the deprecation period of HTMLParser.unescape() should be prolonged.

On other side, this method is not documented, nor in 2.7, nor in 3.x. It is not a part of official API.

[bitdancer]

Nevertheless, our current standing policy is to not remove anything until after 2.7 goes out of maintenance entirely.

[berkerpeksag]

It was removed before and added back with a deprecation warning (because someone was using it).

A little bit off-topic, but it would be great to have a "deprecated APIs in Python 3" list somewhere in the Python documentation (see https://docs.djangoproject.com/en/dev/internals/deprecation/ for an example).

[iritkatriel]

This was pending Python 2 EOL, so should be ok to do now, right?

[orsenthil]

Irit, yes. Serhiy's patch could be converted to a GitHub PR and it can be merged.

[serhiy-storchaka]

It was already removed in bpo-37328. The only not applied part of the patch is adding a What's New entry.

[serhiy-storchaka]

New changeset a33f2c2 by Serhiy Storchaka in branch 'master':
bpo-27032, bpo-37328: Document removing HTMLParser.unescape(). (GH-22288)
a33f2c2

[iritkatriel]

This issue can be closed now.