Better error message when cherry_picker is called in wrong state #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
force-pushed
the
no-in-kansas
branch
from
c3ec09a to
b199f43
Compare
aisk
reviewed
Mar 31, 2024
| try: | ||
| chosen_config_path, config = load_config(config_path) | ||
| except ValueError as exc: | ||
| click.echo("You're not inside a Git tree right now! \U0001F645", err=True) |
There was a problem hiding this comment.
I think this ValueError is expected to be raised by get_sha1_from when executing a git command and an error occurs. But the error may not be caused by the fact that the pwd is not in a git tree; it could be some other errors, like git not being installed.
I suggest just echoing some words like "Got an error when executing git command," and echoing the stderr output from the git command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99.