Fix domain validation #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeridth
force-pushed
the
fix_domain_validation
branch
from
12d4df9 to
0fbf118
Compare
Contributor
Author
|
Failing specs in different python versions. Fixing. |
jmeridth
force-pushed
the
fix_domain_validation
branch
3 times, most recently
from
c1ed4b5 to
72d1da0
Compare
- Updated regex to not allow numeric only TLDs (examples in tests) - Allow for idna encoded domains and test for them (examples in tests) Fixes python-validators#47 Fixes python-validators#123
jmeridth
force-pushed
the
fix_domain_validation
branch
from
72d1da0 to
4d1fca6
Compare
Contributor
Author
|
@kvesteri thank you for the merge. May I inquire when the next pypi release will be? Thank you for creating this project. |
Collaborator
|
Released version 0.14.1 with this included |
Contributor
Author
|
@kvesteri thank you very much. Cheers 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
Fixes #123