Add python version requirement on setup.py #595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include python_requires option on setup for pip to resolve python dependency accordingly. prevent installing the latest flask_restx regardless of python version. fixes python-restx#586
peter-doggart
approved these changes
Jul 24, 2024
|
@jason-the-j I've merged this as #609 to fix some lint errors on the fly. Thanks for your contribution and fix. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
All python versions previous to 3.8 are now end of life and no longer supported.
But, pip automatically installs the latest version of flask_restx on python 3.6 (or any version under 3.8), resulting in ModuleNotFoundError on importlib.metadata which is available starting with python 3.8.
Solution:
include python_requires option when setup for pip to resolve python dependency accordingly.
prevent installing the latest and unsupported flask_restx regardless of python version.
fixes #586