-
Notifications
You must be signed in to change notification settings - Fork 343
Add default swagger filename to Api. #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default swagger filename to Api. #192
Conversation
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
+ Coverage 96.86% 96.88% +0.01%
==========================================
Files 20 20
Lines 2740 2725 -15
==========================================
- Hits 2654 2640 -14
+ Misses 86 85 -1
Continue to review full report at Codecov.
|
karunpoudel-chr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Hello, Thanks for your contribution. Although the code coverage remains unchanged would you mind adding a unit test since you introduce a new option? |
ceea430 to
2bee37e
Compare
|
Hello and thank you for the feedback! I added a test for a non-default swagger name to test_swagger.py. |
2bee37e to
de85b9d
Compare
de85b9d to
ad4f6f3
Compare
|
Hello! I rebased it to latest again, without any failing tests. |
ad4f6f3 to
115a72a
Compare
|
@ziirish Is there anything we can do to get this merge request moving? |
|
@j5awry this is something that could immensely help out my team, are you able to review this? If not, who's someone that can? |
|
Sorry for letting this sit. The change and test look good. If it could be given a quick rebase, that'd be helpful. thanks! |
115a72a to
037fe95
Compare
|
@j5awry sorry for the delay, just rebased! |
|
@j5awry Is there an update on this being released? |
This PR suggests a fix for issue #191: