Update rope to 1.11.0 for multi-threading capabilities #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Dec 18, 2023
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Great work @tkrabel! Just a small comment for you, otherwise looks good to me.
ccordoba12
approved these changes
Dec 18, 2023
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me now, thanks @tkrabel!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #474
rope==1.11.0 now supports
autoimportbeing called by multiple threads.When updating rope, we can add back a unit test that failed due to thread issues. Also, we simplify workspace.py