Skip to content

Prevent faulty third-party plugins to crash the server #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Prevent faulty third-party plugins to crash the server #154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b665d6d
on plugin loading also catch pkg_resources.DistributionNotFound
arian-f Jan 12, 2022
b4ae508
Update pylsp/config/config.py
arian-f Jan 31, 2022
b7a239c
hush the linter
arian-f Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pylsp/config/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def __init__(self, root_uri, init_opts, process_id, capabilities):
for entry_point in pkg_resources.iter_entry_points(PYLSP):
try:
entry_point.load()
except ImportError as e:
except Exception as e: # pylint: disable=broad-except
log.warning("Failed to load %s entry point '%s': %s", PYLSP, entry_point.name, e)
self._pm.set_blocked(entry_point.name)

Expand Down