Skip to content

Update deprecated e999 check #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Update deprecated e999 check #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d98dc3
update deprecated e999 check
jhossbach Jul 15, 2024
c8ca162
keep old e999 check for compatibilty
jhossbach Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
repos:
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.991
rev: v1.10.1
hooks:
- id: mypy
args: [--ignore-missing-imports]

- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.2.1
rev: v0.5.2
hooks:
# Run the linter.
- id: ruff
Expand Down
2 changes: 1 addition & 1 deletion pylsp_ruff/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def create_diagnostic(check: RuffCheck, settings: PluginSettings) -> Diagnostic:
# Ruff intends to implement severity codes in the future,
# see https://github.com/charliermarsh/ruff/issues/645.
severity = DiagnosticSeverity.Warning
if check.code == "E999" or check.code[0] == "F":
if check.code == "None" or check.code == "E999" or check.code[0] == "F":
severity = DiagnosticSeverity.Error

# Check if check.code starts contained in given severities
Expand Down