Skip to content

Fix fixall title suffix #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 16, 2024
Merged

Fix fixall title suffix #86

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
17594aa
none: some gitignore
Shane-XB-Qian Mar 14, 2024
a8cf5ac
fix: clear the meaning of 'fix all'
Shane-XB-Qian Mar 14, 2024
0b2cf23
fix: correct associated test
Shane-XB-Qian Mar 14, 2024
26e454c
none: re-wording
Shane-XB-Qian Mar 15, 2024
21be526
fix: show 'fix all' only when there 'safe' fixes
Shane-XB-Qian Mar 15, 2024
11d1205
remove unnecessary variable, format
jhossbach Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
__pycache__/
*.egg-info/

*.swp
tags
/build/
2 changes: 1 addition & 1 deletion pylsp_ruff/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ def create_fix_all_code_action(
document: Document,
settings: PluginSettings,
) -> CodeAction:
title = "Ruff: Fix All"
title = "Ruff: Fix All (all safe fixes)"
kind = CodeActionKind.SourceFixAll

# No unsafe fixes for 'Fix all', see https://github.com/python-lsp/python-lsp-ruff/issues/55
Expand Down
4 changes: 2 additions & 2 deletions tests/test_code_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ def f():
"Ruff (F401): Disable for this line",
"Ruff (F841): Remove assignment to unused variable `a` (unsafe)",
"Ruff (F841): Disable for this line",
"Ruff: Fix All",
"Ruff: Fix All (all safe fixes)",
]

codeactions_import = [
"Ruff: Organize imports",
"Ruff: Fix All",
"Ruff: Fix All (all safe fixes)",
"Ruff (I001): Disable for this line",
]

Expand Down