Move the package metadata from setup.py to setup.cfg #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
ccordoba12
changed the title
Member
|
Thanks for the reminder @KOLANICH! Please rebase on top of the latest |
ccordoba12
reviewed
Jan 10, 2022
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
I also left a couple of small suggestions for you, then this should be ready.
KOLANICH
force-pushed
the
setup.cfg
branch
2 times, most recently
from
d23a067 to
119556c
Compare
Contributor
Author
|
Thanks for the suggestions, fixed. |
Member
Added `pyproject.toml` Replaced fetching version from a file with fetching a version from version control system tags. Also fixed a bug with incorrect content of `__all__` in `__main__.py`
ccordoba12
changed the title
ccordoba12
approved these changes
May 11, 2022
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @KOLANICH for your help with this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pyproject.toml
Replaced fetching version from a file with fetching a version from version control system tags.
Also fixed a bug with incorrect content of
__all__in__main__.py