Skip to content

Form responses storing and validation #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 12, 2020
Merged

Form responses storing and validation #17

merged 10 commits into from
Dec 12, 2020

Conversation

ks129
Copy link
Member

@ks129 ks129 commented Dec 9, 2020

Closes #8

Created models for form responses, added captcha and blacklist validation and updated user validation. Now also stores data to DB.

Also added duplicate ID validation for forms as side change (found bug when testing).

@ks129 ks129 added area: validation Code relating to validation of user input and Pydantic models. area: route Code that will create a new route on the web application. area: form submission Code relating to the response submission to forms backend. labels Dec 9, 2020
@ks129 ks129 requested a review from jb3 December 9, 2020 17:39
@ghost ghost added the needs 1 approval label Dec 9, 2020
jb3
jb3 previously approved these changes Dec 9, 2020
View reviewed changes
@ghost ghost removed the needs 1 approval label Dec 9, 2020
@jb3
Copy link
Member

jb3 commented Dec 9, 2020

Wrong button, meant to request changes!

@jb3 jb3 dismissed their stale review December 9, 2020 20:56

wrong button

@ghost ghost added the needs 1 approval label Dec 9, 2020
jb3
jb3 requested changes Dec 9, 2020
View reviewed changes
Copy link
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments made above!

This PR looks good and seems like a good base for form responses. Once this is through I'll get to work looking at how to render these forms on the frontend in a good way and how to collect responses.

Thanks!

@jb3
Copy link
Member

jb3 commented Dec 9, 2020

There are a couple of other places where status codes should be returned. We'll also standardise the error format at some point.

Don't worry about those, implement the changes in this PR and I'll open a PR in the next day or so to change things — but they are not critical.

@ks129 ks129 requested a review from jb3 December 10, 2020 20:07
@ghost ghost removed the needs 1 approval label Dec 12, 2020
@jb3 jb3 merged commit 35626c8 into main Dec 12, 2020
@jb3 jb3 deleted the ks123/response-model-endpoint branch December 12, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb3 jb3 jb3 approved these changes

Assignees
No one assigned
Labels
area: form submission Code relating to the response submission to forms backend. area: route Code that will create a new route on the web application. area: validation Code relating to validation of user input and Pydantic models.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add routes for recording form responses
2 participants
@ks129 @jb3