Add api client #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-behjati
approved these changes
Jun 4, 2025
Comment on lines
+25
to
+50
| #[derive(Serialize, Debug, Clone, PartialEq, Eq, PartialOrd, Ord)] | ||
| pub struct Observation<P> { | ||
| pub version: u8, | ||
| #[serde(with = "hex::serde")] | ||
| pub signature: [u8; 65], | ||
| pub body: Body<P>, | ||
| } | ||
|
|
||
| impl<P: Serialize> Observation<P> { | ||
| pub fn try_new(body: Body<P>, secret_key: SecretKey) -> Result<Self, anyhow::Error> { | ||
| let digest = body.digest()?; | ||
| let signature = Secp256k1::new() | ||
| .sign_ecdsa_recoverable(Message::from_digest(digest.secp256k_hash), &secret_key); | ||
| let (recovery_id, signature_bytes) = signature.serialize_compact(); | ||
| let recovery_id: i32 = recovery_id.into(); | ||
| let mut signature = [0u8; 65]; | ||
| signature[..64].copy_from_slice(&signature_bytes); | ||
| signature[64] = recovery_id as u8; | ||
|
|
||
| Ok(Self { | ||
| version: 1, | ||
| signature, | ||
| body, | ||
| }) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
maybe add them to lib.rs :?
Collaborator
Author
There was a problem hiding this comment.
Why we should add it to lib.rs?
Collaborator
There was a problem hiding this comment.
It's nitpiky but boundary wise this doesn't belong to api client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add api client to submit observations to aggregator server