Skip to content

Adapt the Solana best-practice example to the new api + fix CI #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 3, 2022
Merged

Adapt the Solana best-practice example to the new api + fix CI #85

merged 7 commits into from
Nov 3, 2022

Conversation

@ali-behjati
Copy link
Collaborator

@ali-behjati ali-behjati commented Nov 3, 2022 •
edited
Loading

Fixes #84

This change:

  • Updates the example to use the latest api
  • Pins Solana rust dependencies on the Solana example and test contract to 1.13.3 (latest released Solana mainnet)
  • Uses Solana cli tools of v1.14.7 that have sbf instead of bpf. It seems that since bpf is outdated, for whatever reason, crates.io index cannot detect a suitable dependency for time that matches the flags/architecture. This change solves that problem.

@ali-behjati ali-behjati requested a review from jayantk November 3, 2022 12:02
@ali-behjati ali-behjati mentioned this pull request Nov 3, 2022
Closed
jayantk
jayantk approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@ali-behjati ali-behjati merged commit 75e2742 into main Nov 3, 2022
@ali-behjati ali-behjati deleted the adapt-api branch November 3, 2022 15:57
@ali-behjati ali-behjati mentioned this pull request Nov 3, 2022
Closed
@ozgb ozgb mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayantk jayantk jayantk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ali-behjati @jayantk @yhzhang0128