Replace get_prev_price with better methods #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-behjati
force-pushed
the
abehjati/add-latest-methods
branch
from
3efa1e6 to
c8caa40
Compare
Reisen
reviewed
Aug 16, 2022
jayantk
approved these changes
Aug 16, 2022
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
looks good to me. i think the duration thing would be nice, assuming it is supported. If not, not a big deal.
Reisen
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason
current_timeis an argument there is that the SDK is chain agnostic and there is no notion of system current time.This PR will fix #14 and #29 too and bumps the version.