Bug fix + improvement #46
Conversation
|
|
||
| # When min_publishers is high it means that the price is not production-ready | ||
| # yet and it is still being tested. We need no alerting for these prices. | ||
| if price_account.min_publishers >= 10: |
There was a problem hiding this comment.
This is equivalent to "beta" on the website and filters not ready prices.
|
|
||
|
|
||
| class PriceFeedAggregateCheck(PriceFeedCheck): | ||
| class PriceFeedOfflineCheck(PriceFeedCheck): |
There was a problem hiding this comment.
The name was ambiguous. Offline is a better name.
|
|
||
| distance = abs( | ||
| self.__state.slot_aggregate_attempted - self.__state.slot_aggregate | ||
| self.__state.latest_block_slot - self.__state.latest_trading_slot |
There was a problem hiding this comment.
A price feed can go stale without its status becoming non-trading. This check relies on checking the latest slot with the latest trading slot (which includes non-trading checks before)
| return True | ||
|
|
||
| # Pass if price has been stale for a long time | ||
| if distance > self.__abandoned_slot_distance: |
There was a problem hiding this comment.
Some feeds are abandoned but still in our list.
|
|
||
|
|
||
| class PublisherAggregateCheck(PublisherCheck): | ||
| class PublisherWithinAggregateConfidenceCheck(PublisherCheck): |
There was a problem hiding this comment.
Better name again.
pyth_observer/check/publisher.py
Outdated
|
|
||
| # Pass if publisher slot is far from aggregate slot | ||
| distance = abs(self.__state.slot - self.__state.aggregate_slot) | ||
| if distance > 25: |
There was a problem hiding this comment.
This value is hard-coded but it is not very important. It is used to filter out the non-trading or behind publishers. We can change it later in the future.
| return True | ||
|
|
||
| # Skip if no aggregate | ||
| if self.__state.price_aggregate == 0: |
There was a problem hiding this comment.
When aggregate status is trading this is impossible.
| else: | ||
| raise RuntimeError("Invalid check") | ||
|
|
||
| text = self.check.error_message() |
There was a problem hiding this comment.
Added publisher_name to publisher state and the code here is therefore simpler.
Also with the previous logic if a new publisher was added this code would crash as it couldn't look up the name.
ali-behjati
requested review from
cctdaniel,
jayantk and
thmzlt
and removed request for
thmzlt
This PR mostly fixes some logic bugs or improve them. Also updates the calendar for the new year.
Please see my comments for further explanation.