Skip to content

Fix some bugs + some improvements #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2023
Merged

Fix some bugs + some improvements #45

merged 2 commits into from
Jan 3, 2023

Conversation

@ali-behjati
Copy link
Contributor

@ali-behjati ali-behjati commented Jan 2, 2023 •
edited
Loading

These are small changes that:

  • Fix the bug that prices from Pythnet were not getting updated
  • Fix a bug in custom configurations for some price feeds
  • Finish a ToDo item about handling price service query params
  • Modify the pre-commit checks to fix the problems in addition to checking

I bumped the version so we can deploy it right after this change.

cctdaniel
cctdaniel approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@cctdaniel cctdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇🏻

thmzlt
thmzlt approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@thmzlt thmzlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ali-bahjati

@ali-behjati ali-behjati merged commit 140ce22 into main Jan 3, 2023
@ali-behjati ali-behjati deleted the bug-fix branch January 3, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thmzlt thmzlt thmzlt approved these changes

@jayantk jayantk Awaiting requested review from jayantk

+1 more reviewer

@cctdaniel cctdaniel cctdaniel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ali-behjati @thmzlt @cctdaniel