[hermes] Add storage tests + refactor #907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jayantk
approved these changes
Jun 21, 2023
| }, | ||
| }; | ||
|
|
||
| pub fn create_dummy_price_feed_message_state( |
Contributor
There was a problem hiding this comment.
(if you made this take an array of times_and_slots: [(i64, Slot)] you could shorten the tests below a bit)
Collaborator
Author
There was a problem hiding this comment.
I tried this now but the test readability was not very good. I decided to keep it as it is.
Reisen
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tests to the local storage to make sure it works fine. During the testing I realized that moka's Cache is not working as we expect it to work (it doesn't evict items as we want to) so we removed it and instead adopted a simple queue (or BTreeMap). We might replace it with a more efficient implementation in the future but will do in separate PRs (if needed).
Also, I added a new type alias of
FeedIdin the Message struct and renamedidtofeed_idin pythnet_sdk to make the id more clear. I bumped version to 2.0.0 to get away from solana versioning and have proper version control on this crate. Lastly, updated the cosmwasm contract with this breaking change.