[hermes] Move GuardianSet sourcing from Ethereum to PythNet #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Reisen
force-pushed
the
reisen/hermes-pythnet-guardiansets
branch
2 times, most recently
from
9443650 to
08e5c5f
Compare
ali-behjati
reviewed
Jun 15, 2023
hermes/src/store.rs
Outdated
| pub storage: StorageInstance, | ||
| pub observed_vaa_seqs: Cache<u64, bool>, | ||
| pub guardian_set: RwLock<Option<Vec<GuardianAddress>>>, | ||
| pub guardian_set: RwLock<BTreeMap<u32, Vec<[u8; 20]>>>, |
Collaborator
There was a problem hiding this comment.
maybe use GuardianSet here too?
ali-behjati
approved these changes
Jun 15, 2023
Reisen
force-pushed
the
reisen/hermes-pythnet-guardiansets
branch
from
08e5c5f to
af696ac
Compare
Reisen
force-pushed
the
reisen/hermes-pythnet-guardiansets
branch
from
af696ac to
5215031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code currently relies on reading GuardianSet state updates from Ethereum, this PR switches that to relying on reading GuardianSet accounts from Wormhole deployed on PythNet. We should be safe to do this as Wormhole upgrade all other target chain contracts before Ethereum, so we will not run into a situation where we receive VAA's that are signed by keys we have not yet seen.