Implement accumulator updates for cosmwasm #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jayantk
approved these changes
Jun 12, 2023
| to_price_feed(&mut feed3).publish_time += 1; | ||
| to_price_feed(&mut feed1).price *= 2; | ||
| to_price_feed(&mut feed2).price *= 2; | ||
| to_price_feed(&mut feed3).price *= 2; |
Contributor
There was a problem hiding this comment.
nitpick: with a name like to_price_feed, this doesn't sound like it should mutate the underlying data. that said, I can't think of a better name for it, so 🤷
| StdError::from(PythContractError::InvalidAccumulatorMessage) | ||
| ); | ||
| } | ||
|
|
ali-behjati
approved these changes
Jun 13, 2023
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
Very nice!
I think it would be good to add a few more tests that i mentioned in an inline comment. Please add them before merging.
The fee for accumulator messages is base fee times the number of messages but the logic remains the same for the batch method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.