Encapsulate parameters to proposeX methods #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
guibescos
reviewed
Jun 9, 2023
| const msAccount = await this.getMultisigAccount(); | ||
| const newProposals = []; | ||
|
|
||
| const remote = targetCluster === undefined || targetCluster != this.cluster; |
Contributor
There was a problem hiding this comment.
I think it should default to local if targetCluster is undefined
guibescos
approved these changes
Jun 9, 2023
guibescos
reviewed
Jun 9, 2023
| return WORMHOLE_ADDRESS[this.cluster]; | ||
| } | ||
|
|
||
| // TODO: does this need a cluster argument? |
Contributor
There was a problem hiding this comment.
Why would it need a cluster argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick refactor to make this code a little easier to work with before I go about adding more functionality. The code right now instantiates a bunch of parameters in several different places (e.g., the SquadsMesh), which are needed to call
proposeInstructions. This change makes a class to hold all of these parameters so we can instantiate them all one time instead of repeating the code.I suggest looking at
propose.tsfirst. The other changes are pretty mechanical.