[remote-executor] Isolate wormhole-solana crate #843

guibescos · 2023-05-24T22:29:30Z

The goal of this PR is :

Make remote-executor use the new version of wormhole-sdk
Move the wormhole-solana (that wormhole doesn't have) to its own repo and update it to use wormhole-sdk

Wormhole team needs to :

Fix the crate patch issue with serde_wormhole
Decide what happens to wormhole-solana

vercel · 2023-05-24T22:29:36Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
example-oracle-amm	⬜️ Ignored (Inspect)			May 25, 2023 11:52pm
xc-admin-frontend	⬜️ Ignored (Inspect)			May 25, 2023 11:52pm

guibescos · 2023-05-25T20:26:09Z

governance/remote_executor/rust-toolchain.toml

@@ -0,0 +1,2 @@
+[toolchain]
+channel = "1.66.1"


Drive-by pin toolchain

guibescos · 2023-05-25T20:26:34Z

governance/remote_executor/programs/remote-executor/src/tests/executor_simulator.rs

+            std::env::current_dir()
+                .unwrap()
+                .join(Path::new("../../target/deploy/remote_executor.so")),
+        );


Newer versions of solana can't find the binary with the previous logic

Can you explain why? Inherently suspicious of needing relative paths.

In previous versions (1.13.x) when you ran cargo test-bpf, it would set an environment variable BPF_OUT_DIR and that's how the code would find the binary.
New versions (1.14.x) don't seems to set it, so find_file fails.

Maybe it has to do with them trying to migrate to test-sbf and deprecating test-bpf.

Yeah I recall the BPF_OUT_DIR issues as well. Can you mention what might be the reason it's not doing it before we merge this? Don't worry if it takes too much time you can merge over this comment, it would just be nice to know what changed here for other solana related work.

guibescos · 2023-05-25T20:26:43Z

.github/workflows/remote-executor.yml

      - name: Install Solana
        run: |
-          sh -c "$(curl -sSfL https://release.solana.com/stable/install)"
+          sh -c "$(curl -sSfL https://release.solana.com/v1.14.18/install)"


I had to bump this

guibescos · 2023-05-25T20:27:06Z

governance/remote_executor/Cargo.toml

 overflow-checks = true
+
+[patch.crates-io]
+serde_wormhole = { git = "https://github.com/wormhole-foundation/wormhole", tag = "v2.17.1" }


This patch.crate-io wormhole thing is getting out of control, wormhole needs to fix

Agreed, reasonable fix for now though. Let's ask for publishing.

guibescos · 2023-05-25T20:49:08Z

wormhole_attester/Cargo.lock

Attester cargo lock updated since attester governance cli uses remote-executor

Reisen · 2023-05-26T01:08:27Z

governance/remote_executor/programs/remote-executor/src/tests/executor_simulator.rs

+            std::env::current_dir()
+                .unwrap()
+                .join(Path::new("../../target/deploy/remote_executor.so")),
+        );


Can you explain why? Inherently suspicious of needing relative paths.

Reisen · 2023-05-26T01:09:17Z

governance/remote_executor/programs/remote-executor/Cargo.toml

 anchor-lang = {version = "0.25.0", features = ["init-if-needed"]}
-wormhole-solana = { git = "https://github.com/guibescos/wormhole", branch = "reisen/sdk-solana"}
-wormhole-core = { git = "https://github.com/guibescos/wormhole", branch = "reisen/sdk-solana"}
+wormhole-solana = { git = "https://github.com/guibescos/wormhole-solana", rev="f14b3b54c1e37e1aaf8c2ac2a5e236832ffdb3c2"}


We should really get away from this, maybe we can chat about what needs to be upstreamed. We're running into this in pythnet too. I believe this was based on my original PR that had plans to revive, we should push for it if possible.

This is a temporary home.
Two options from here :

Its own repo (maybe switch from my personal github to wormhole or pyth org)

Make it part of sdk/rust/ in the wormhole monorepo

Reisen · 2023-05-26T01:09:28Z

governance/remote_executor/cli/src/main.rs


-            let vaa = VAA::from_bytes(vaa_bytes.clone())?;
+            let vaa: Vaa<&RawMessage> = serde_wormhole::from_slice(&vaa_bytes)?;
+            let (header, body): (Header, Body<&RawMessage>) = vaa.into();


Nice nice nice.

Reisen · 2023-05-26T01:10:07Z

governance/remote_executor/Cargo.toml

 overflow-checks = true
+
+[patch.crates-io]
+serde_wormhole = { git = "https://github.com/wormhole-foundation/wormhole", tag = "v2.17.1" }


Agreed, reasonable fix for now though. Let's ask for publishing.

guibescos changed the title ~~Point to another wormhole sdk~~ [remote-executor] Point to another wormhole sdk May 24, 2023

guibescos added 4 commits May 25, 2023 14:59

Point to another wormhole sdk

fa8b418

Works

94c447a

Reset this dir

9c25f6e

Refresh cargo lock

bcf423e

guibescos force-pushed the fix-wormhole-sdk branch from cd41728 to bcf423e Compare May 25, 2023 20:00

Bump solana

fa58fb5

guibescos commented May 25, 2023

View reviewed changes

Pin git packages

60d18fc

guibescos commented May 25, 2023

View reviewed changes

wormhole_attester/Cargo.lock

Copy link

Contributor Author

guibescos May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attester cargo lock updated since attester governance cli uses remote-executor

guibescos added 3 commits May 25, 2023 15:58

Allow large errors

01152dd

Update to the right wormhole-solana

4402790

Fix cli

6eb0b4d

guibescos changed the title ~~[remote-executor] Point to another wormhole sdk~~ [remote-executor] Isolate wormhole-solana crate May 25, 2023

guibescos added 2 commits May 25, 2023 18:49

Add cargo lock

08beb57

Remove print statement

839e1dd

guibescos marked this pull request as ready for review May 26, 2023 00:39

Reisen reviewed May 26, 2023

View reviewed changes

Reisen approved these changes May 26, 2023

View reviewed changes

guibescos merged commit 73c2af2 into main May 26, 2023

guibescos deleted the fix-wormhole-sdk branch May 26, 2023 19:02

[remote-executor] Isolate wormhole-solana crate #843

[remote-executor] Isolate wormhole-solana crate #843

Uh oh!

Conversation

guibescos commented May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guibescos May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guibescos May 25, 2023

Choose a reason for hiding this comment

Uh oh!

Reisen May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guibescos May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reisen May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guibescos May 25, 2023

Choose a reason for hiding this comment

Uh oh!

guibescos May 25, 2023

Choose a reason for hiding this comment

Uh oh!

Reisen May 26, 2023

Choose a reason for hiding this comment

Uh oh!

guibescos May 25, 2023

Choose a reason for hiding this comment

Uh oh!

Reisen May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reisen May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guibescos May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reisen May 26, 2023

Choose a reason for hiding this comment

Uh oh!

Reisen May 26, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

guibescos commented May 24, 2023 •

edited

Loading

vercel bot commented May 24, 2023 •

edited

Loading

guibescos May 25, 2023 •

edited

Loading

Reisen May 26, 2023 •

edited

Loading

guibescos May 26, 2023 •

edited

Loading

Reisen May 26, 2023 •

edited

Loading

Reisen May 26, 2023 •

edited

Loading

Reisen May 26, 2023 •

edited

Loading

guibescos May 26, 2023 •

edited

Loading