[pythnet] Update serialization for MerkelPath/MerkleAccumulator #830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jayantk
approved these changes
May 22, 2023
| } | ||
|
|
||
| Some(serialized) | ||
| } |
Contributor
There was a problem hiding this comment.
why did this need to be added?
Contributor
Author
There was a problem hiding this comment.
Ali asked for this as he is serializing these in hermes by hand, this is also not the right place for this and I am hoping to replace the distributed hand-rolled serialization soon, but as the PR is modifying one serializer and Ali needed another it made sense to couple the change-set for now, I can remove this and leave the hand-rolling in hermes or do it in a separate PR if you prefer, but I'm planning to rip this out so I figured It's fine to place the current serialization in the same place until I move it all out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to help Hermes, it changes the message format serialized by the validator to include the slot and ring size instead of the ring index. This is because hermes ideally would be able to associate accumulators with a slot, the current ring index can simply be calculated as
slot % ring_sizewhen needed. This adds a small amount of overhead to messages of 64 gas. The serialize function added to MerklePath is also for Hermes.This PR also fixes clippy/rustfmt pre-commit hooks so there's a little noise.