[price-pusher] support for aptos #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 11, 2023 22:03
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
guibescos
reviewed
May 12, 2023
Contributor
There was a problem hiding this comment.
Feels like too many changes here for just adding 1 package. What version of npm are you using?
Contributor
Author
There was a problem hiding this comment.
I updated the package-lock.json with the latest commit. Can you please take a look?
guibescos
reviewed
May 12, 2023
guibescos
reviewed
May 12, 2023
guibescos
reviewed
May 12, 2023
guibescos
reviewed
May 12, 2023
Contributor
guibescos
left a comment
guibescos
left a comment
There was a problem hiding this comment.
I really like how you reused parts of the other pushers. That's awesome.
Main comment is figuring out this package-lock.json thing. Seems like a lot of integrate hashes disappeared
added 3 commits
May 12, 2023 13:35
ali-behjati
reviewed
May 12, 2023
ali-behjati
approved these changes
May 12, 2023
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
Nice and clean ser 🔥
guibescos
approved these changes
May 12, 2023
guibescos
approved these changes
May 12, 2023
guibescos
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.