-
Notifications
You must be signed in to change notification settings - Fork 308
[price-service] Improve vaa validation #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
| mainnet: { | ||
| index: 3, | ||
| addresses: [ | ||
| "0x58CC3AE5C097b213cE3c81979e1B9f9570746AA5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this break when the guardian set changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it will break. Hopefully by the next guardian set change we won't have this service running anymore 😅 But if we had this running we should let it accept both the old and the new. We can periodically check the source of truth for the guardian (the wormhole eth contract) but to have 0 downtime we still need to support transition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should be able to use the grpc call to get the current guardian set
something similar to how these work - https://github.com/wormhole-foundation/wormhole/tree/main/sdk/js/src/rpc
import { publicrpc } from "@certusone/wormhole-sdk-proto-web";
const { GrpcWebImpl, PublicRPCServiceClientImpl } = publicrpc;
import { NodeHttpTransport } from "@improbable-eng/grpc-web-node-http-transport";
// need to use the NodeHttpTransport when running this in a node environment
export async function getGuardianSet(
host: string,
extraGrpcOpts = {transport: NodeHttpTransport()}
) {
const rpc = new GrpcWebImpl(host, extraGrpcOpts);
const api = new PublicRPCServiceClientImpl(rpc);
return await api.GetCurrentGuardianSet({});
}
58b0fdb to
204ce92
Compare
204ce92 to
8e1e860
Compare
No description provided.