Skip to content

Conversation

@Reisen
Copy link
Contributor

@Reisen Reisen commented May 4, 2023

This PR brings the pyth submodule from PythNet into the crosschain repository under the name pythnet_sdk such that the validator can use it as a dependency instead. The code is identical so no changes have been introduced so the PR should be straight forward in concept even if it appears large. It also moves the message_buffer program into the same directory, the benefit of this is a Cargo.lock can be introduced under pythnet/ that will allow locking the dependencies of both to the same versions which will be useful when introducing message buffer types into the SDK.

The goal here is to make the pyth module a general PythNet SDK module that PythNet itself can also depend on.

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
example-oracle-amm ⬜️ Ignored (Inspect) May 4, 2023 5:34pm
xc-admin-frontend ⬜️ Ignored (Inspect) May 4, 2023 5:34pm

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Reisen Reisen force-pushed the reisen/pythnet-sdk branch from 1b394ea to 5471b4d Compare May 4, 2023 17:32
@Reisen Reisen force-pushed the reisen/pythnet-sdk branch from 5471b4d to e201629 Compare May 4, 2023 17:34
@Reisen Reisen merged commit 677343c into main May 4, 2023
@Reisen Reisen deleted the reisen/pythnet-sdk branch May 4, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants