[cosmwasm] instantiate contracts on multiple chains #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
added 13 commits
May 4, 2023 15:00
ali-behjati
changed the title
ali-behjati
reviewed
May 5, 2023
ali-behjati
reviewed
May 5, 2023
ali-behjati
reviewed
May 5, 2023
ali-behjati
reviewed
May 5, 2023
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
Nice! I left some comments and would appreciate if you clarify them.
jayantk
reviewed
May 5, 2023
Contributor
jayantk
left a comment
jayantk
left a comment
There was a problem hiding this comment.
nice. I have mostly minor comments. The one thing I would like to see is the checksum checking, because there is a potential security hole there (and we should be paranoid about this stuff). Let's write down the expected checksums in this repo as a config file and then we can check the downloads against that.
ali-behjati
approved these changes
May 11, 2023
ali-behjati
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains: