[js-packages] Build all packages before publishing #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
guibescos
changed the title
ali-behjati
approved these changes
May 1, 2023
jayantk
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve the following problem.
The way the script currently works is it only builds the packages it aims to publish. However if your package depends on another package that's not being published, the whole thing will fail because that other package hasn't been built.
https://github.com/pyth-network/pyth-crosschain/actions/runs/4852553452/jobs/8647678135
in this job after a bugfix to
price-service-clientpublishprice-service-clientfailed because we're not publishingprice-service-sdk.There are two solutions :