[Price pusher client] Fix axios bug by downgrading, bump all dependents #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
guibescos
commented
Apr 27, 2023
| "dependencies": { | ||
| "@pythnetwork/price-service-sdk": "*", | ||
| "@types/ws": "^8.5.3", | ||
| "axios": "^1.2.5", |
Contributor
Author
There was a problem hiding this comment.
I downgraded axios and it seemed to fix the problem
Contributor
There was a problem hiding this comment.
lol what... nice find though
cctdaniel
approved these changes
Apr 28, 2023
ali-behjati
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was found by Brett from telegram. Basically EvmConnection wasn't working in a React app because of some axios weirdness.
Minimal example here :
https://github.com/guibescos/test-connection
I want to make this change and make a release ASAP.