Skip to content

Conversation

@0xfirefist
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
example-oracle-amm ⬜️ Ignored (Inspect) Apr 20, 2023 10:33am
xc-admin-frontend ⬜️ Ignored (Inspect) Apr 20, 2023 10:33am

Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add documentation to the README explaining what this does, when you will need it, and how to run it?

# docker build -f Dockerfile.wormhole -o artifacts .

FROM cosmwasm/workspace-optimizer-arm64:0.12.11@sha256:a00c01c2fdae8c74d6a9db95fa7b0cbb8e81101ce23a78487012e363d632fee9 AS builder
# FROM cosmwasm/workspace-optimizer:0.12.11@sha256:b6b0b1d5ed76dafd0ec0d3812a1e7a275316cf862fd6d0a918f14d71c4cb187f AS builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a little janky -- do you have to comment / uncomment this depending on the architecture? (you may be able to fix this by passing the platform flag to docker, or asking users to change their shell to use emulation)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the case.
I don't think passing platform flag will work. As both of these are separate images and not one image supporting multiple architecture.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added comment for it.
Arm64 ones are only to be used while testing and not for production usage

@0xfirefist 0xfirefist merged commit 259f012 into main Apr 20, 2023
@0xfirefist 0xfirefist deleted the wormhole-stub branch April 20, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants