[price_service] Let callers specify VAA encoding #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
cctdaniel
reviewed
Apr 14, 2023
Contributor
cctdaniel
left a comment
cctdaniel
left a comment
There was a problem hiding this comment.
nice! this seems to be more user friendly 🙇🏻♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a lot of questions about how to convert the base64 VAAs into hex and whatnot. This PR adds an "encoding" parameter to all of the endpoints that return a VAA which lets you pick the thing you want.
Note that I added a "0x" option which is hex, but with a 0x prepended. The EVM APIs seem to need this in various places.
UPDATE
I changed my mind about how this should work. The encoding parameter is itself hard for people to figure out, so I replaced it with a
target_chainargument which is self-explanatory. The server will map the target chains to the desired encoding.