Skip to content

[sui 6/x] - Pyth unit tests #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Apr 30, 2023
Merged

[sui 6/x] - Pyth unit tests #757

merged 25 commits into from
Apr 30, 2023

Conversation

@optke3
Copy link
Contributor

@optke3 optke3 commented Apr 10, 2023 •
edited
Loading

Summary

  • Write a full suite of unit tests for Pyth exercising price feed creation and price feed updates. Confirm that price info objects behave as expected
  • Incorporate latest changes from wormhole/sui_integration_v2
  • Add assert_package_upgrade_cap check to init_and_share_state
  • Inspect transaction effects and make sure the right number of PriceInfoObjects are created and shared with each call to create_price_feeds
  • Implement update_price_feeds_if_fresh
  • Make some important edits to update_cache loop
    1. throw error if price info object not found
    2. add && found == false condition to make sure that we update at most one price info object

Testing

  • sui move test
    Sui version: sui 0.29.1-d6ebeaa32

Integration Remaining Todos

  • Contract upgradeability

optke3 added 22 commits March 22, 2023 17:13
@optke3
state getters and setters, change Move.toml dependency to sui/integra…
9303a21 
…tion_v2
@optke3
finish state.move
b69917e
@optke3
add new line to pyth
0380a1f
@optke3
use deployer cap pattern for state module
e799fc6
@optke3
sui pyth
9ac8860
@optke3
update price feeds, dynamic object fields, Sui object PriceInfoObject
05d2121
@optke3
register price info object with pyth state after creation
096f31a
@optke3
sui governance
690107d
@optke3
some newlines
7966b57
@optke3
Merge remote-tracking branch 'origin/main' into sui/governance_
7301c48
@optke3
error codes
e0fc803
@optke3
update and comment
84ec0d3
@optke3
unit tests for pyth.move, add UpgradeCap to Pyth State (will be used …
c13c23d 
…for contract upgrades)
@optke3
updates
4dd4c41
@optke3
test_get_update_fee test passes
b8877f6
@optke3
fix test_get_update_fee and test_update_price_feeds_corrupt_vaa
5dcb613
@optke3
test_update_price_feeds_invalid_data_source
edf6735
@optke3
test_create_and_update_price_feeds
48ccac6
@optke3
test_create_and_update_price_feeds_success and test_create_and_update…
1c2dd4a 
…_price_feeds_price_info_object_not_found_failure
@optke3
test_update_cache
b1b6624
@optke3
update
a9e37b4
@optke3
test_update_cache_old_update
2965e29
@vercel
Copy link

vercel bot commented Apr 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xc-admin-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2023 7:49pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
example-oracle-amm ⬜️ Ignored (Inspect) Apr 30, 2023 7:49pm

@optke3 optke3 requested a review from Reisen April 10, 2023 21:45
@optke3 optke3 marked this pull request as ready for review April 10, 2023 21:45
Base automatically changed from sui/clock_error_codes_and_more to main April 30, 2023 19:39
@optke3 optke3 merged commit d8c69a6 into main Apr 30, 2023
@optke3 optke3 deleted the sui/unit_tests_pyth_and_more branch April 30, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Reisen Reisen Reisen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@optke3 @Reisen